A few review comments for V8.

===
1.

+               if (password_expire_warning > 0 && vuntil < PG_INT64_MAX)
+               {
+                       TimestampTz result = (vuntil - now) / USECS_PER_SEC; /* 
in seconds */
+
+                       if (result <= (TimestampTz) password_expire_warning)
+                               MyClientConnectionInfo.warning_message =
+                                               psprintf("your password will 
expire in %d day(s)", (int)
(result / 86400));
+               }

Please consider localization of the warning message.


2. typo fix

a. `Controls how many time ...` should be `Controls how much time ...`.

b. `Sets how many time before password expire to emit ...` should be
`Sets how much time before password expires to emit ...`

Reply via email to