> On 27 Dec 2022, at 04:32, Michael Paquier <[email protected]> wrote: > > Sure. Done that too, and applied the change after a last lookup.
Sorry for bumping old thread. I'm toying with enabling wal_consistency_checking here and there. I've found the way with PG_TEST_EXTRA=wal_consistency_checking, but also I was thinking what if we enable it everywhere... Overall it seems difficult to just add PGOPTION="-c wal_consistency_checking=all" on a buildfarm animal. This happens mostly because frontends cannot connect with unprivileged role with wal_consistency_checking in PGOPTION. But this particular test of pg_waldump fails due to LSN comparison logic. The test expects LSN in saved file to be strictly less than LSN in file name. This is violated when wal_consistency_checking is enabled: LSNs are equal. Maybe we can relax the test here? Thanks! Best regards, Andrey Borodin.
0001-pg_waldump-tests-less-strict-LSN-comparison-for-bloc.patch
Description: Binary data
