Thank you, I have made the changes and attached the patch. Regards, Gyan
On Tue, Jan 20, 2026 at 7:55 AM vignesh C <[email protected]> wrote: > On Tue, 20 Jan 2026 at 06:28, Gyan Sreejith <[email protected]> > wrote: > > > > Thank you for all your input. I have attached the latest version of the > patch that includes the changes proposed by Vignesh and Amit. Please let me > know if you have any questions or suggestions. > > 1) Currently you are creating directories like > specifiedlogdir_timestamp for each run, so it generates log > directories like: > logdir_2026-01-20-18-15-55.267510 > logdir_2026-01-20-18-16-49.468882 > > Instead can you change it to specifiedlogdir/exec_timestamp1. > specifiedlogdir/exec_timestamp2, etc > > + populate_timestamp(timestamp, > sizeof(timestamp)); > + log_dir = psprintf("%s_%s", optarg, > timestamp); > + opt.log_dir = pg_strdup(log_dir); > + canonicalize_path(opt.log_dir); > + > + if (stat(opt.log_dir, &statbuf) != 0) > + { > + if (errno == ENOENT) > + { > + mkdir(opt.log_dir, > S_IRWXU); > > > 2) Your patch is based on a slightly older code, it does not apply on > HEAD, Kindly rebase your patch on top of HEAD, > > Regards, > Vignesh >
v3-0001-Add-a-new-argument-l-logdir-to-pg_createsubscribe.patch
Description: Binary data
