Hi,
I noticed that ApplyLogicalMappingFile() has an unused argument.
If there is no specific reason for keeping it, I think it could be
removed. I have attached a small patch that removes this argument.
Regards,
Yugo Nagata
--
Yugo Nagata <[email protected]>
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index a0293f6ec7c..e39c0677749 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -5361,7 +5361,7 @@ DisplayMapping(HTAB *tuplecid_data)
* transaction c) applied in LSN order.
*/
static void
-ApplyLogicalMappingFile(HTAB *tuplecid_data, Oid relid, const char *fname)
+ApplyLogicalMappingFile(HTAB *tuplecid_data, const char *fname)
{
char path[MAXPGPATH];
int fd;
@@ -5544,7 +5544,7 @@ UpdateLogicalMappings(HTAB *tuplecid_data, Oid relid, Snapshot snapshot)
elog(DEBUG1, "applying mapping: \"%s\" in %u", f->fname,
snapshot->subxip[0]);
- ApplyLogicalMappingFile(tuplecid_data, relid, f->fname);
+ ApplyLogicalMappingFile(tuplecid_data, f->fname);
pfree(f);
}
}