Hi Andy, Thanks for the patch.
On Fri, Jan 30, 2026 at 6:23 PM Andy Fan <[email protected]> wrote: > > At 2026-01-30 13:13:37, "Michael Paquier" <[email protected]> wrote: > > Hi, > > >On Fri, Jan 30, 2026 at 10:29:41AM +0800, Andy Fan wrote: > >> The following comment looks out of date now. should we fix it as following? > > > >Yes, the code returns XLREAD_FAIL is we cannot find a record when not > >in standby mode. Thanks for the report. > > Thanks for double check. patch attached. > WaitForWALToBecomeAvailable can also return XLREAD_WOULDBLOCK when the caller set nonblocking. The comment only talks about XLREAD_FAIL vs “waits in standby,” so it still doesn’t describe that third outcome. That omission pre-dates this patch, should we expand the comment mention the nonblocking case as well? -- Best, Xuneng
