I wrote:
> Hence, I suggest the attached alternative solution, at least for
> the first pass at this.  I've checked that this works on both AIX
> (cfarm119) and NetBSD/ppc (mamba's host).

I realized that there was only one other local label in s_lock.h,
so that

+ * Ordinarily, we'd code the branches here using GNU-style local symbols,

felt a little silly: local labels would now be the minority usage.
And to me, this approach is actually superior to a local label.
"1:" has zero mnemonic value while "TAS%=_fail" conveys something
useful.  So I converted that other usage too and documented this as
the new standard approach for s_lock.h.  Pushed at 0c9f46c42.

                        regards, tom lane


Reply via email to