Hi, Thank you for all your help!
This thread has a couple of discussions and it can be hard to follow; I think it would be better if we can separate these discussions. This would make it easier to follow the topics. What I have in my mind is: * There are four patches in this thread, three of them COPY FROM related: v3, v4 and v5. One of them is COPY TO related. So, I guess it would be better to move COPY TO discussion to another thread. * Manni suggested to stop benchmarking v4.2 COPY FROM patch, I agree with him. Then it would be easier to address reviews and do benchmarking. * Kazar applied Neil's review on top of v3 and benchmarked, v3 seems to perform better but I think flushing line_buf needs more benchmarking. * I am planning to create a new version (v6) of the patch, which will be basically v3 with one less branching (moving !in_quote check under is_csv and else). So that it would be easy to review and follow the thread for new reviewers. What do you think about these? Do you think these make sense and / or do you have any other suggestions? -- Regards, Nazir Bilal Yavuz Microsoft
