Michael Paquier 写于 2026/2/11 19:06:
On Wed, Feb 11, 2026 at 05:22:27PM +0800, wangpeng wrote:
> The function pgstat_report_checksum_failures_in_db(), file
> pgstat_database.c,
> currently emits a log message referring to "conflicts", which seems wrong.
> As the function name suggesting, the log message should refer to "checksum
> failures".
Right, that's strange. It looks like a copy-pasto, but I am not sure
from where.
> - elog(WARNING, "could not report %d conflicts for DB %u",
> + elog(WARNING, "could not report %d checksum failures for DB %u",
> failurecount, dboid);
We may as well use "for database" here. Let's improve it a bit more
while on it, even if it is not translated.
--
Michael
Thanks for your review. Updated "for DB" to "for database" in v2.
Best regards,
Wang Peng
From e54f3608a5f140d4d49db376567fc224d64d4720 Mon Sep 17 00:00:00 2001
From: Wang Peng <[email protected]>
Date: Tue, 10 Feb 2026 22:16:24 -0500
Subject: [PATCH v2] Fix wrong log in pgstat_report_checksum_failures_in_db()
Author: Wang Peng <[email protected]>
---
src/backend/utils/activity/pgstat_database.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/utils/activity/pgstat_database.c
b/src/backend/utils/activity/pgstat_database.c
index 6309909..933dcb5 100644
--- a/src/backend/utils/activity/pgstat_database.c
+++ b/src/backend/utils/activity/pgstat_database.c
@@ -200,7 +200,7 @@ pgstat_report_checksum_failures_in_db(Oid dboid, int
failurecount)
Assert(entry_ref);
if (!entry_ref)
{
- elog(WARNING, "could not report %d conflicts for DB %u",
+ elog(WARNING, "could not report %d checksum failures for
database %u",
failurecount, dboid);
return;
}
--
1.8.3.1
