Aditya Kamath <[email protected]> writes:
> +# -blibpath must contain ALL directories where we should look for libraries
> +libpath := $(shell echo $(subst -L,:,$(filter -L/%,$(LDFLAGS))) | sed -e's/
> //g'):/usr/lib:/lib
> +
> +# when building with gcc, need to make sure that libgcc can be found
> +ifeq ($(GCC), yes)
> +libpath := $(libpath):$(dir $(shell gcc -print-libgcc-file-name))
> +endif
> +
> +rpath = -Wl,-blibpath:'$(rpathdir)$(libpath)’
> These lines are no longer required, and we have removed it in v12 patch as
> well. And this is the root cause of GNU tests failing.
Hmm, I'm not sure how "these lines are not required" squares with
"the tests fail after we remove them". More generally, we do need
rpath support for many installation scenarios. So even if you can
make it work for your own scenario without that, I think the
answer is "you can use --disable-rpath" not "we should remove rpath
support for everybody".
> After removing the lib path and path from Makefile.aix we get the below
> library search paths which is what we need to run test cases or run binaries,
> ***Import File Strings***
> INDEX PATH BASE MEMBER
> 0
> ../../../src/port:../../../src/common:../../../src/fe_utils:../../../src/interfaces/libpq:/opt/freeware/lib:/opt/freeware/lib/gcc/powerpc-ibm-aix7.3.0.0/13/ppc64:/opt/freeware/lib/gcc/powerpc-ibm-aix7.3.0.0/13/../../../ppc64:/opt/freeware/lib/gcc/powerpc-ibm-aix7.3.0.0/13:/opt/freeware/lib/gcc/powerpc-ibm-aix7.3.0.0/13/../../..:/usr/lib:/lib
You should be quite scared of that result, because the relative paths
will only work in a build tree not for an installed server executable.
My recollection is that I put those lines back after discovering
that "make install; make installcheck" didn't work without 'em.
That was on the GCC farm's machine, so there may also be an
AIX 7.2 vs 7.3 difference involved here, and/or some difference
in the configuration of the gcc compiler.
I intend to test the final patch version on cfarm119 before
committing, but it has been down for a couple days, no doubt
because of OSUOSL's ongoing data center move.
regards, tom lane
