On Wed, Jan 14, 2026 at 7:11 PM Soumya S Murali <[email protected]> wrote: > Thank you for the detailed review and suggestions. > Based on the feedback, I have updated the patch to make the checkpoint > and restart point log formatting fully consistent between start and > completion log messages. The completion messages now use the same > format as the start messages without parentheses. I have also replaced > the term "reason" with the term "flags". The patch has been rebuilt > and validated with make check and the full recovery TAP test suite, > and I have manually verified the resulting log output to confirm the > expected formatting. I am attaching the updated patch for further > review. Please let me know if any additional adjustments are needed.
Thanks for updating the patch!
+ if (flags & CHECKPOINT_IS_SHUTDOWN)
+ APPEND_REASON("shutdown");
+ if (flags & CHECKPOINT_END_OF_RECOVERY)
+ APPEND_REASON("end-of-recovery");
I still think it would be simpler to construct the checkpoint flags string
with snprintf() rather than introducing a new macro. Please see
the attached patch.
- if ($node_primary->log_contains("checkpoint complete: ", $logstart))
+ if ($node_primary->log_contains("checkpoint complete:", $logstart))
I don't think this change is necessary.
I've also updated the commit message in the attached patch.
Regards,
--
Fujii Masao
v8-0001-Log-checkpoint-request-flags-in-checkpoint-comple.patch
Description: Binary data
