> On 19 Feb 2026, at 18:44, Dmitry Dolgov <[email protected]> wrote:
> I've been experimenting with ssl recently, and found it's useful to have > more information exposed via contrib/sslinfo, in particular > ssl_supported_groups and ssl_shared_groups to show TLS groups extension. In general I'm not opposed to adding more information to sslinfo. +PG_FUNCTION_INFO_V1(ssl_supported_groups); +Datum +ssl_supported_groups(PG_FUNCTION_ARGS) The supported groups is sent as a TLS extension, and we already have ssl_extension_info() for listing extension values. Shouldn't this be a part of that function for consistency? --- /dev/null +++ b/contrib/sslinfo/sslinfo--1.3.sql @@ -0,0 +1,56 @@ +/* contrib/sslinfo/sslinfo--1.3.sql */ No need to spin a new 1.3 file, the upgrade file from 1.2 to 1.3 is sufficient since the extension machinery will play the files in order to reach 1.3. +CREATE FUNCTION ssl_shared_groups() RETURNS text Why not return this as text[] rather than a delimited string? The patch also lacks docs updates for the new functions. -- Daniel Gustafsson
