Re: pgsql: libpq: Grease the protocol by default

[Tom Lane]

I wrote:
> It's not obvious to me where the problem lies.

Ah: the step that is failing is where TestUpgradeXVersion.pm
is trying to make a comparison dump from the old server:

        # use the NEW pg_dumpall so we're comparing apples with apples.
        setinstenv($self, "$installdir", $save_env);
        system( qq{"$installdir/bin/pg_dumpall" $dump_opts -p $sport -f }
                  . qq{"$upgrade_loc/origin-$oversion.sql" }
                  . qq{> "$upgrade_loc/$oversion-dump1.log" 2>&1});
        return if $?;

So I was right to suspect that we can't fix this without modifying
the buildfarm client.

                        regards, tom lane