On Wed, Feb 25, 2026 at 8:09 PM Zsolt Parragi <[email protected]> wrote: > > Both look good to me.
Pushed 0002 after making sure AVX-512 detection still worked, thanks for the review! I think 0003 needs a link to the Intel manual for the XCR symbol values, and I'll push shortly after I add that. > This isn't part of the patch, and it seems harmless, but while > reviewing the CRC functions, I noticed that pg_crc32c.h is > inconsistent with its dllimport markers, pg_comp_crc32c has 3 > different declarations, and only 1 of them is marked PGDLLIMPORT. Yeah, I think that crept in during development to keep Windows CI building with a not-for-commit test module. I'll remove it soon. -- John Naylor Amazon Web Services
