Hi,
While reading the subscription code I noticed one error message that doesn't
follow the project's style: in check_remote_recovery_state() in
subscriptioncmds.c, the errmsg() for the "publisher is in recovery" case ends
with a period. The convention elsewhere (including the similar message a few
lines above in the same file) is no trailing period.
The attached one-line patch removes the trailing period from that string. No
behavior change.
Thanks,
Sahitya Chandra
---
src/backend/commands/subscriptioncmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/commands/subscriptioncmds.c
b/src/backend/commands/subscriptioncmds.c
index 9e21d7a7df9..724637cff5b 100644
--- a/src/backend/commands/subscriptioncmds.c
+++ b/src/backend/commands/subscriptioncmds.c
@@ -2993,7 +2993,7 @@ check_pub_dead_tuple_retention(WalReceiverConn *wrconn)
if (remote_in_recovery)
ereport(ERROR,
errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
- errmsg("cannot enable retain_dead_tuples if the
publisher is in recovery."));
+ errmsg("cannot enable retain_dead_tuples if the
publisher is in recovery"));
ExecDropSingleTupleTableSlot(slot);
--
2.43.0