On Sat, Mar 7, 2026 at 12:31 PM Amit Kapila <[email protected]> wrote: > > On Thu, Mar 5, 2026 at 2:23 PM Jeff Davis <[email protected]> wrote: > > > > Few other minor comments: > ====================== > 1. > +# Replicate the changes without columns > +$node_publisher->safe_psql('postgres', "CREATE TABLE tab_no_col()"); > +$node_publisher->safe_psql('postgres', > + "INSERT INTO tab_no_col default VALUES"); > > I don't see a subscriber-side table or verification code to verify the > above test. >
I see that the committed version (8185bb5347) has this part of the test, isn't that test incomplete, if not, tell me what am I missing? It seems I have sent this message after you have committed the last version. > 2. > + Oid subserver BKI_LOOKUP_OPT(pg_foreign_server); /* If connection uses > + * server */ > + > > Isn't it better to keep this along with other oids in the beginning of > the catalog, say after subowner? It will also avoid padding before > subserver field. > We can probably consider this one as well though there is no correctness issue as such. -- With Regards, Amit Kapila.
