On Fri, Mar 6, 2026 at 4:53 PM Chao Li <[email protected]> wrote: > PFA v6.
Thanks for updating the patch! > The two test cases on table level “IF EXISTS” are removed. So, now the patch > adds totally 4 test cases: 2 for omitting COLUMN, 2 for combinations of > column level “IF [NOT] EXISTS” and omitting COUMN. The latest patch doesn't seem to include the combination of column-level IF NOT EXISTS for ADD COLUMN and omitting COLUMN. Based on your patch, I updated the regression tests as follows and pushed the changes: +ALTER FOREIGN TABLE ft1 ADD c11 integer; -- omit COLUMN +ALTER FOREIGN TABLE ft1 DROP c11; -- omit COLUMN I moved the ALTER FOREIGN TABLE DROP test into the section that lists the other existing ALTER FOREIGN TABLE DROP COLUMN tests. Regarding table-level IF EXISTS tests, it seemed to me that most ALTER FOREIGN TABLE ADD/DROP variants should also be tested there, following the existing structure in foreign_data.sql. So I added some additional cases, for example ALTER FOREIGN TABLE IF EXISTS ADD COLUMN IF NOT EXISTS. Regards, -- Fujii Masao
