Hi Zsolt, Thanks for the report and the test case!
> Good catch, Zsolt. You're right ― the return value of > coerce_to_boolean() must be assigned back to te->expr, otherwise > any implicit cast (e.g., a user-defined type with an assignment > cast to boolean) is silently discarded. > > The fix is straightforward: > > foreach_ptr(TargetEntry, te, defineClause) > te->expr = (Expr *) coerce_to_boolean(pstate, (Node *) te->expr, > "DEFINE"); > > I've confirmed that your example query produces incorrect results > without the fix (the truthyint value is evaluated as-is without > the cast) and correct results with it. > > Patch 13 is attached with the fix and a regression test case based > on your example. Yeah, current patch needs to be fixed. Question is, the output of the expression of DEFINE clause must be a strict boolean or, it is allowed to accept an expression coercive to boolean? If we prefer the former, we should use exprType() instead. Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
