On Mon, Mar 16, 2026 at 11:39 AM Yi Ding <[email protected]> wrote: > > > At 2026-03-13 21:50:07, "Fujii Masao" <[email protected]> wrote: > >On Fri, Mar 13, 2026 at 2:51 PM Yi Ding <[email protected]> wrote: > >> The new test added in v1 makes sense to me. A small suggestion is that to > >> verify if a field is really null, we can do: > >> > >> ALTER FOREIGN TABLE agg_bad OPTIONS (ADD on_error 'set_null'); > >> SELECT a, b IS NULL FROM agg_bad; > > > >Since the file_fdw test runs "\pset null _null_", a NULL value is displayed > >as > >"_null_". So you can verify that the value is NULL by checking whether > >"_null_" is shown. > > > >One could argue that this cannot be distinguished from the literal text value > >"_null_". However, relying on "\pset null _null_" is sufficient for this > >test, > >I think. > > > >Regards, > > > >-- > >Fujii Masao > > > > Sounds reasonable,that addressed my comment.
I've pushed the patch. Thanks! Regards, -- Fujii Masao
