Antonin Houska <[email protected]> wrote: > Alvaro Herrera <[email protected]> wrote:
> > - the name pgoutput_repack sounds wrong to me. I would rather say > > rpck_output, repack_output, repack_plugin, ... or something. I don't > > understand where the suffix "output" comes from in the name > > "pgoutput", but it sounds like arbitrary nonsense to me. > > No strong preference here ... One more problem related to the replication slot is that, due to the call of CheckSlotPermissions() in setup_logical_decoding(), REPLICATION privilege is required for REPACK (CONCURRENTLY) to run. That's not too user-friendly. I think the reason to require the REPLICATION privilege is that, in generic case, the output plugin can access data of any table in the database. However REPACK uses one particular plugin and that plugin only decodes changes of one particular table. Thus I think we don't really need to call CheckSlotPermissions(). Do I seem to miss something? -- Antonin Houska Web: https://www.cybertec-postgresql.com
