On 16/03/26 08:45, Ranier Vilela wrote:
Hi.
Per Coverity.
CID 1645716: (#1 of 1): Resource leak (RESOURCE_LEAK)
8. leaked_storage: Variable str going out of scope leaks the storage
str.data points to.
The function *postgres_fdw_connection* leaks the contents of
var str.data
Once that function *cstring_to_text* palloc the contents
must be necessary to free the var str.data.
patch attached.
Hi,
Thanks for the patch, it looks correct to me. I've searched for this
pattern `PG_RETURN_TEXT_P(cstring_to_text(.*.data` in other places and
I've just found on postgres_fdw/connection.c
I've also search for other cases of `return cstring_to_text(...)`
usages and I didn't found anything that seems suspicious.
Tests are also passing.
--
Matheus Alcantara
EDB: https://www.enterprisedb.com
