On 2018-09-24 15:29:38 +1200, Thomas Munro wrote: > On Sun, Sep 23, 2018 at 10:15 PM Andrey Borodin <x4...@yandex-team.ru> wrote: > > Here's the patch with amcheck functionality for GiST. > > Hi Andrey, > > Windows doesn't like it[1]: > > contrib/amcheck/verify_gist.c(163): error C2121: '#' : invalid > character : possibly the result of a macro expansion > [C:\projects\postgresql\amcheck.vcxproj] > > That's: > > + MemoryContext mctx = AllocSetContextCreate(CurrentMemoryContext, > + "amcheck context", > +#if PG_VERSION_NUM >= 110000 > + ALLOCSET_DEFAULT_SIZES); > +#else > + ALLOCSET_DEFAULT_MINSIZE, > + ALLOCSET_DEFAULT_INITSIZE, > + ALLOCSET_DEFAULT_MAXSIZE); > +#endif > > Not sure what's gong on there... perhaps it doesn't like you to do > that in the middle of a function-like-macro invocation > (AllocSetContextCreate)?
But note that the version dependent code shouldn't be present in /contrib anyway. Greetings, Andres Freund
