On Fri, Mar 27, 2026 at 03:28:16PM -0400, Tom Lane wrote: > Andrew Dunstan <[email protected]> writes: > > On 2026-03-26 Th 12:29 PM, Tom Lane wrote: > >> I'm not sure I want to expend the brain cells to figure out whether > >> this is a correct/complete patch. If pg_bsd_indent were less of an > >> undercommented spaghetti-code nightmare, maybe fixing it here would > >> be reasonable. But as things stand, why don't we just fix this in > >> the perl wrapper, as attached? > > > Well, I thought we were trying to reduce the fixups we did in pgindent. > > Yeah, other things being equal I too would prefer to fix it within > pg_bsd_indent. But other things are not equal: the complexity > and reviewability of the proposed v2 patch are not comparable to > a one-liner fix in the wrapper.
I think the only way forward if we want to continue modifying pg_bsd_indent is to rename most of the variables and add some sanity to the code. -- Bruce Momjian <[email protected]> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
