On Sun, Mar 29, 2026 at 2:16 AM SATYANARAYANA NARLAPURAM <[email protected]> wrote: > I am still reviewing / understanding the patch, a couple quick comments based > on my review. > > 1. Looks like off-by-one in the for loop in the patch > v18-0015-WIP-aio-io_uring-Use-IO-size-not-IO-queue-to-tri.patch
You're right. Andres independently fixed this bug on our working branch just yesterday. > 2. NIT comment: _bt_endpoint return type changed to IndexScanBatch from bool > in the patch v18-0005-Add-interfaces-that-enable-index-prefetching.patch. > But the places it is returning false would be good to replace with NULL. > Though false is treat as 0/NULL and no compiler errors, it improves the > readability of the code. I agree. This was a simple oversight, not a deliberate choice. It'll be fixed in the next version. Thanks -- Peter Geoghegan
