Hi Andrew On 30/03/2026 11:44, Andrew Dunstan wrote: > Here's a very minor tidy up: > > - Split Datum xmlcanonicalize(PG_FUNCTION_ARGS) across two lines > - Fixed variable declaration alignment > - Replaced 11-line verbose comment with a single-line /* Canonicalize > the entire document using C14N 1.1 */ > - Moved #include <libxml/c14n.h> to alphabetical position > - Removed unnecessary if (doc) / if (xmlbuf) guards on the success-path > cleanup > - Added spaces after casts: (xmlDocPtr) doc, (xmlChar *) xmlbuf, > (xmlChar **) &xmlbuf > > I note that your function returns xml, whereas Tom's suggestion was for > a function returning text. I don't think there was any discussion on the > point.
Thanks for the code review! In your v22, I can't find the changes you mentioned. Is it possible that the wrong file was attached, or were these changes intended for v23? Best, Jim
