On Fri, Aug 24, 2018 at 03:37:17PM +0100, Alexandra Ryzhevich wrote: > CONNECT ON DATABASE privilege is granted to public by default (so > all users by default can select pg_database_size()) and > REVOKE CONNECT ... FROM <username> command doesn't impact > user's privileges. The only way to revoke connect privilege from user > is to revoke it from public. That's why maybe it will be less harmful > just to remove pg_database_size tests at all. But will it be better to > remove pg_tablespace_size() tests also? if possible costs are more > harmful than not testing this code path then I'll remove these tests > also.
Sorry for the delay, Alexandra, and thanks for the new version. I have removed the tests related to pg_tablespace_size as they are costly and those for vacuum_cost_delay as we didn't gain more with those tests. The rest has been committed, which makes a good first cut. -- Michael
signature.asc
Description: PGP signature
