Hi Ashutosh,

Thanks for addressing my comments in the latest patch. The documentation
additions look correct, and the new Part E test cases in
053_synchronized_standby_slots_quorum.pl exercise the SS_SLOT_LAGGING path
as requested.

I noticed that Shveta caught a behavioral regression between v20260318 and
v20260323 regarding inactive slots that had already caught up being
incorrectly blocked. The fix in v20260326 (splitting into
SS_SLOT_INACTIVE_LAGGING and SS_SLOT_ACTIVE_LAGGING, and counting a slot as
caught up when its restart_lsn >= wait_for_lsn regardless of activity)
looks correct to me.

Overall I feel the patch is in good shape.

Regards,
Surya Poondla

Reply via email to