On Wed, 1 Apr 2026 at 05:19, Melanie Plageman <[email protected]> wrote: > > Thanks for the reply! I have committed the patches in this thread and > marked the CF entry accordingly.
Yeah, realised that after sending the email. > On Mon, Mar 30, 2026 at 10:17 PM David Rowley <[email protected]> wrote: > > > > I looked at v48-0001 and it looks fine to me. I've only minor quibbles > > about you using foreach() instead of foreach_int() and foreach_node() > > for populating the new Bitmapsets in standard_planner(). > > Good point. I forgot about those. Attached patch fixes that (since the > code was already committed). Since it's in already, maybe it'd be worth doing something more widespread after the freeze is over, changing just the ones new to v19. git diff 2652835d3efa003439ecc23d5fc3cf089c5952a6.. -- *.c | grep -E "^\+\s+foreach\(" or with a bit more context: git diff 2652835d3efa003439ecc23d5fc3cf089c5952a6.. -- *.c | grep -E "(^\+\s+foreach\(|^---)" The mixed node ones don't qualify, but it shouldn't be too hard to filter those out manually. David
