> On Apr 1, 2026, at 14:48, Fujii Masao <[email protected]> wrote:
>
> On Wed, Mar 25, 2026 at 2:54 PM Fujii Masao <[email protected]> wrote:
>>> Perhaps, we could wait
>>> for some time to hear from others.
>>
>> +1.
>>
>> If there are no further comments in the next few days, and given the limited
>> time before feature freeze, I'm inclined to at least apply the 0001 patch
>> (which simply lowers the log level to DEBUG1).
>
> Since there were no objections for about a week, I've pushed the 0001
> patch. Thanks!
>
> If any issues or concerns are raised, let's consider applying the 0002 patch!
>
> Regards,
>
> --
> Fujii Masao
TBH, I’m not quite sure what practical benefit this patch set provides.
In 0001, some messages are changed from LOG to DEBUG1. But then 0002 introduces
trace_logical_decoding_messages, whose default is DEBUG1, so with the default
setting those messages are effectively promoted back to LOG again. That seems
to cancel out the behavior change from 0001 by default.
Also, looking at where trace_logical_decoding() is applied in 0002, all the
call sites currently pass DEBUG1. So in practice, if a user sets
trace_logical_decoding_messages to anything higher than DEBUG1, all of those
messages disappear. That makes it feel more like an on/off switch than a
mechanism for filtering messages by level.
So at least to me, the overall value of this patch is still not very clear.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
