On Fri, Mar 27, 2026 at 2:05 PM shihao zhong <[email protected]> wrote: > > On Tue, Mar 24, 2026 at 6:11 PM Zsolt Parragi <[email protected]> > wrote: > > > > Hello! > > > > blk_read_time and blk_write_time doesn't seem to work, they show 0 to > > me even after some workloads, and I don't see any assignments in the > > code. The testcase also checks for "blk_read_time >= 0" which > > trivially succeeds. > > > > blocks_fetched is also misleading, it includes both reads and cache > > hits. pg_stat_database calls this column blocks_read, and properly > > substracts blocks_hit from it. > > > > + rel->pgstat_info->reltablespace = rel->rd_locator.spcOid; > > > > Shouldn't this be included in TwoPhasePgStatRecord / > > pgstat_twophase_postcommit? > > > > > > Hi Zsolt and Jian, > > Thanks for the feedback. I've attached v3, addressing all comments. > Notably, I've included tuple-level stats in the pg_stat_tablespace > view to align with the addition of SpaceOid in TwoPhasePgStatRecord. > > Thanks, > Shihao
Rebase with head.
pg_stat_tablespace_final_v4.patch
Description: Binary data
