Hi, On 2026-04-07 15:27:45 -0700, Lukas Fittl wrote: > On Tue, Apr 7, 2026 at 3:19 PM Andres Freund <[email protected]> wrote: > I think renaming makes sense - both to make sure extensions reconsider > how they use it, and because "totaltime" is a bad name anyway, because > its not just about timing (and hasn't been for many releases). > > "query_instr[_options]" seems reasonable to me, although we could drop > the "query_" since it'd be "queryDesc->query_instr" vs > "queryDesc->instr".
Done that way. I earlier pushed 0002 too. > > Kinda wonder about having > > EXPLAIN (ANALYZE BUFFERS totals_only, WAL totals_only) ...; > > > > in plenty cases that'd be all one needs, at substantially lower cost. > > True. I don't like the name "totals_only", but I like the concept. I spent all of three seconds coming up with it... :) > Today someone has to go to pg_stat_statements to get just the total > numbers, without running them for all nodes with EXPLAIN ANALYZE (and > incurring its overhead). Yep. Greetings, Andres Freund
