On Wed, Apr 08, 2026 at 03:21:38PM -0400, Tom Lane wrote: > Nathan Bossart <[email protected]> writes: >> FWIW that elog() shouldn't be emitting anything from the view, unless >> something is broken. > > [ looks again... ] Oh, you mean because pg_stat_get_autovacuum_scores > passes 0 for elevel instead of any of the valid elevel constants. > Can you say "undocumented cowboy hack"? I'd be happier if we added > something like "#define LOG_NEVER 0 /* Never emit this message */" > to elog.h and used that.
Yeah... I should've done that originally. Here's a patch that I'll apply in the next day or so, barring objections. -- nathan
>From 1ce7c01b3e7f594749c4f5edb6e9c14729337779 Mon Sep 17 00:00:00 2001 From: Nathan Bossart <[email protected]> Date: Wed, 8 Apr 2026 16:19:33 -0500 Subject: [PATCH 1/1] add LOG_NEVER --- src/backend/postmaster/autovacuum.c | 3 ++- src/include/utils/elog.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c index bd626a16363..f9fa874b79f 100644 --- a/src/backend/postmaster/autovacuum.c +++ b/src/backend/postmaster/autovacuum.c @@ -3676,7 +3676,8 @@ pg_stat_get_autovacuum_scores(PG_FUNCTION_ARGS) avopts = extract_autovac_opts(tup, RelationGetDescr(rel)); relation_needs_vacanalyze(form->oid, avopts, form, - effective_multixact_freeze_max_age, 0, + effective_multixact_freeze_max_age, + LOG_NEVER, &dovacuum, &doanalyze, &wraparound, &scores); if (avopts) diff --git a/src/include/utils/elog.h b/src/include/utils/elog.h index 440a02dd147..9c1e75c59ac 100644 --- a/src/include/utils/elog.h +++ b/src/include/utils/elog.h @@ -23,6 +23,7 @@ struct Node; /* Error level codes */ +#define LOG_NEVER 0 /* Never emit this message */ #define DEBUG5 10 /* Debugging messages, in categories of * decreasing detail. */ #define DEBUG4 11 -- 2.50.1 (Apple Git-155)
