On Mon, Apr 13, 2026 at 9:52 AM vignesh C <[email protected]> wrote: > > On Sun, 12 Apr 2026 at 00:32, Shlok Kyal <[email protected]> wrote: > > Hi Vignesh and Shveta, > > > > Thanks for reviewing the patches. > > I have addressed the comments and attached the updated patch. > > Few comments for the first patch: > 1) I felt these also could be moved to first patch: > - * Gets list of table oids that were specified in the EXCEPT clause for a > + * Gets list of relation oids that were specified in the EXCEPT clause for a >
I noticed all these, but since we are actually fetching sequences in patch002,. I thought changing comments made more sense in patch002 as done by Shlok currently. But I don't have a strong opinion here, so fine with this too. > 2) Similarly here too: > - * The returned tables are locked in ShareUpdateExclusiveLock mode in order > to > - * add them to a publication. > + * The returned relations are locked in ShareUpdateExclusiveLock mode in > order > + * to add them to a publication. > > 3) Similarly here too: > /* > - * Add listed tables to the publication. > + * Add listed relations to the publication. > */ > > 4) Similarly here too: > - /* Must be owner of the table or superuser. */ > + /* Must be owner of the relation or superuser. */ > > 5) Ordering issue here, PublicationRelation should be after > PublicationRelKind: > diff --git a/src/tools/pgindent/typedefs.list > b/src/tools/pgindent/typedefs.list > index ea95e7984bc..ff20501223c 100644 > --- a/src/tools/pgindent/typedefs.list > +++ b/src/tools/pgindent/typedefs.list > @@ -2461,7 +2461,7 @@ PublicationPartOpt > PublicationRelInfo > PublicationRelKind > PublicationSchemaInfo > -PublicationTable > +PublicationRelation > > Regards, > Vignesh > >
