On Mon, Apr 13, 2026 at 4:21 PM Chao Li <[email protected]> wrote: > I think the issue is that rewriteTargetListIU() removes generated columns > from the target list, as described by this comment:
> Later, when the rule action is rewritten, ReplaceVarsFromTargetList() cannot > find a target list entry for NEW.gen. For UPDATE rules, the missing NEW > column is handled with REPLACEVARS_CHANGE_VARNO, so it falls back to > referencing the original target relation row, which gives the old value. I came to the same conclusion. > One possible fix is to build a new target list that adds generated columns > back when there are rules to fire. I tried the solution locally with some > quick and dirty code and it seems to fix both stored and virtual generated > columns for me. I think a simpler fix might be to expand generated column references in the NEW relation to their generation expressions before ReplaceVarsFromTargetList resolves NEW references, so that the base column Vars within the expressions can be correctly resolved. Something like attached. - Richard
v1-0001-Fix-incorrect-NEW-references-to-generated-columns.patch
Description: Binary data
