Hi,

while reading https://www.postgresql.org/docs/devel/postgres-fdw.html  I've 
noticed that there is a single bracket on one line of the CREATE FOREIGN TABLE 
example.

Browsing through other docs (e,g. 
https://www.postgresql.org/docs/devel/sql-createtable.html ) there doesn't seem 
to be a rule for that but if there is a single bracket (e.g. CREATE TABLE 
distributors), the options that follow usually start at position one and are 
not indented (or they follow directly after the bracket).

The examples in file_fdw (https://www.postgresql.org/docs/devel/file-fdw.html) 
follow a mix of options which directly follow the bracket and on a new line.

Attached a small patch which makes it looking a bit better, at least in my 
opinion.

Regards
Daniel
diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml
index b81f33732fb..bf54f8937c4 100644
--- a/doc/src/sgml/postgres-fdw.sgml
+++ b/doc/src/sgml/postgres-fdw.sgml
@@ -1470,9 +1470,9 @@ CREATE USER MAPPING FOR local_user
 CREATE FOREIGN TABLE foreign_table (
         id integer NOT NULL,
         data text
-)
-        SERVER foreign_server
-        OPTIONS (schema_name 'some_schema', table_name 'some_table');
+) 
+SERVER foreign_server
+OPTIONS (schema_name 'some_schema', table_name 'some_table');
 </programlisting>
 
    It's essential that the data types and other properties of the columns

Reply via email to