Hi, thanks for the test! > One question: > The original code did not apply MAXALIGN() to SizeOfXLogRecord before > adding it. In practice SizeOfXLogRecord is likely already MAXALIGN'd > (given typical record header layout), but could you confirm whether > MAXALIGN() here is a correctness fix, a defensive no-op, or something > that requires a separate note in the commit message? > > Otherwise the change looks good to me, and I think it's a reasonable > cleanup.
I apply the MAXALIGN() to keep it consistent with ReserveXLogSwitch(), the value seems unchanged though. Attach v2 which is more efficient. -- Regards, ChangAo Chen
v2-0001-Keep-the-return-value-of-XLogInsertRecord-for-XLO.patch
Description: Binary data
