On Tue, Apr 28, 2026 at 9:46 AM shveta malik <[email protected]> wrote: > > On Mon, Apr 27, 2026 at 9:51 PM Dilip Kumar <[email protected]> wrote: > > > > On Mon, Apr 27, 2026 at 3:08 PM shveta malik <[email protected]> wrote: > > > > > > Few comments on 001 alone: > > > > > > > > > 1) > > > postgres=# create publication pub1 for all tables except (table > > > temp_table); > > > ERROR: cannot specify relation "temp_table" in the publication EXCEPT > > > clause > > > DETAIL: This operation is not supported for temporary tables. > > > > > > postgres=# create publication pub1 for all tables except (table > > > pg_conflict.pg_conflict_16395); > > > ERROR: cannot add relation "pg_conflict.pg_conflict_16395" to publication > > > DETAIL: This operation is not supported for conflict log tables. > > > > > > We shall change the error message for CLT in alignement with new > > > EXCEPT error message added recently. > > > > Yeah we should do that. I see the string we used in > > check_publication_add_relation() is non-schema qualified e.g. If you > > see the example below, the schemaname is omitted in the error message. > > Ideally, I would like this to be schema qualified but that can be > > fixed separately. > > I agree. Initially I thought it might not be needed for temp table > error. But this could be confusing for unlogged tables. I created 2 > tables: public.t1 (logged) and s1.t1 (unlogged), the error became > unclear for unlogged tables as it referred to t1 instead of s1.t1. > Yes, this can be done in a new thread.
Right, I've created that as a base patch before making my changes, so I will post it shortly in a separate thread. -- Regards, Dilip Kumar Google
