Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION

[Amit Kapila]

On Mon, Apr 27, 2026 at 1:59 PM Nisha Moond <nisha.moond...@gmail.com> wrote:
>
> On Mon, Apr 27, 2026 at 11:03 AM Lakshmi N <lakshmin....@gmail.com> wrote:
> >
> > Hi hackers,
> >
> > In CreateSubscription(), the subretentionactive catalog column (declared as
> > bool in pg_subscription.h) is populated using Int32GetDatum() instead of
> > BoolGetDatum():
> >
> > This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
> > ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().
> >
> > The attached patch fixes this to use BoolGetDatum(), matching both the
> > catalog definition and the ALTER path.
> >
>
> +1
> This looks like an oversight in commit a850be2.
>

Pushed.

-- 
With Regards,
Amit Kapila.