On 2026-04-29, Chao Li wrote: >> Looks good to me. However, I did change OidIsValid() and !OidIsValid() >> back to (oid) and (!oid) conditions to be consistent with the rest of >> the code. > > In the file, I also see: > ``` > if (pgrelid == InvalidOid) > ``` > > Should we take this opportunity to change to use OidIsValid() > everywhere in the file? As this feature is new to PG19, we can cleanup > the inconsistency before releasing v19. Otherwise some people might > also file a cleanup patch for this in the future.
Yeah, I find "if (oid)" a rather terrible coding pattern. The negative one is perhaps not so bad, but I'd keep both cases similar by using the macro in both, for consistency. -- Álvaro Herrera
