Hi, On Mon, May 4, 2026 at 6:40 AM Tom Lane <[email protected]> wrote:
> SATYANARAYANA NARLAPURAM <[email protected]> writes: > > VACUUM FULL silently turns columns added via ALTER TABLE ... ADD COLUMN > ... > > DEFAULT <const> into NULL > > on all pre-existing rows. The issue exists for other operations like > > CLUSTER, REPACK. > > That is a seriously awful bug. Fortunately it is not in any shipping > release. A quick bisect run agrees that it broke here: > > 28d534e2ae0ac888b5460f977a10cd9bb017ef98 is the first bad commit > commit 28d534e2ae0ac888b5460f977a10cd9bb017ef98 (HEAD) > Author: Álvaro Herrera <[email protected]> > Date: Mon Apr 6 21:55:08 2026 +0200 > > Add CONCURRENTLY option to REPACK > > > Patch attached. Added a regression test in fast_default.sql covering > > VACUUM FULL, CLUSTER, and REPACK on a table with fast-default columns > > including a NOT NULL CHECK column. > > I don't know if this is the best code fix (I don't like putting extra > checks into a loop condition like this). But I agree we need some > more tests covering this area. > Thanks for reviewing! Attached v2 patch. Agreed, tried to optimize LOC in V1. Before the change loop was not breaking early, I fixed that as well in V2. Thanks, Satya
v2-0001-VACUUM-FULL-silently-NULL-out-fast-default-columns.patch
Description: Binary data
