On Mon, May 04, 2026 at 12:40:19PM -0400, Tom Lane wrote: > Another amusing diff I noticed: > > --- a/src/backend/partitioning/partbounds.c > +++ b/src/backend/partitioning/partbounds.c > @@ -5713,7 +5713,7 @@ check_parent_values_in_new_partitions(Relation parent, > * 3. In case new partitions don't contain the DEFAULT partition and the > * partitioned table does not have the DEFAULT partition, the following > * should be true: the sum of the bounds of new partitions should be > equal > - & to the bound of the split partition. > + * & to the bound of the split partition. > * > * parent: partitioned table > * splitPartOid: split partition Oid > > Clearly, this is somebody's off-by-one-key typo, and the correct > fix is s/&/*/. I suspect that fixing that manually is the most > expedient answer, rather than trying to make pg_bsd_indent smart > enough to DTRT.
+1. This patch has been rather good at finding small mistakes like this, which I've been manually fixing along the way. -- nathan
