> On May 5, 2026, at 03:57, Ayush Tiwari <[email protected]> wrote:
>
> Hi,
>
> While looking at the SQL/PGQ property graph error paths, I noticed a
> few small cleanups in propgraphcmds.c.
>
> The attached patch fixes a user-visible error message from "mismatching
> properties names" to "mismatching property names”,
I think changing “properties names” to “property names” is correct.
I wonder if we can also change “mismatching” to “mismatched”, so the error
message is:
```
"mismatched property names in definition of label \"%s\""
```
> and moves a
> ReleaseSysCache() call before an ERROR ereport in
> check_element_properties().
>
> The existing code should be cleaned up by
> the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> placed after ereport(ERROR) was unreachable.
>
Agreed.
> The regression expected output is updated for the changed error text.
>
> [On a separate note, it might be better to change all "vertexes" to
> "vertices",
> haven't included that in the patch though since the other one is not exactly
> wrong?]
>
> Regards,
> Ayus
> <v1-0001-Clean-up-property-graph-error-messages.patch>
So, v1 LGTM. Only thing is that I think we can also make “mismatching” to
“mismatched” in the errmsg.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
