Hello - server = GetForeignServer(subform->subserver); + server = GetForeignServer(sub->serverid);
Couldn't we also move this inside the if? +/* + * Return the subscription's connection string, loading it into the + * subscription memory context if necessary. + * + * GetSubscription must be called earlier to set sub->serverid, because ACL + * checks are performed there. + */ +char * +GetSubscriptionConnInfo(Subscription *sub) This is related to Ajin's comment earlier, the part about ACL check seems incorrect to me.
