On Fri, May 8, 2026 at 11:34 AM cca5507 <[email protected]> wrote: > > Hi, > > Maybe we want to add "free_parsestate(pstate);" after the "EndCopyFrom()" as > well?
What actual issue could occur if free_parsestate() is not called there? Since pstate->p_target_relation does not seem to be used afterward, omitting free_parsestate() appears mostly harmless to me. Bascailly calling free_parsestate() after make_parsestate() seems intuitive, but from a quick grep I found several places that call make_parsestate() without a corresponding free_parsestate(). Regards, -- Fujii Masao
