(2018/10/01 19:42), Michael Paquier wrote:
On Mon, Jul 23, 2018 at 02:17:38PM +0530, Ashutosh Bapat wrote:
I used perform instead of execute since the later is usually
associated with local operation. I added "foreign" in the name of the
function to indicate that it's executed on foreign server. I am happy
with "remote" as well. I don't think "one" and "single" make any
difference. I don't like "parameterized" since that gets too tied to
the method we are using rather than what's actually being done. In
short I don't find any of the suggestions to be significantly better
or worse than the name I have chosen. Said that, I am not wedded to
any of those. A committer is free to choose anything s/he likes.
Fujita-san, you are registered as a reviewer of this patch. Are you
planning to look at it soon?
Yeah, I'm planning to work on this immediately after fixing the issue
[1], because it still seems to me wise to work on it after addressing
that issue. (I'll post an updated version of the patch for that tomorrow.)
It looks useful to me to rework this code
anyway to help with future maintenance,
Agreed.
so in the worst case I could
always look at it. For now I have moved it to the next commit fest.
Thanks for taking care of this!
Best regards,
Etsuro Fujita
