On 2026-May-15, Fujii Masao wrote: > BTW, while testing REPACK boolean options, I found two other issues > in their parsing. > > First, REPACK (CONCURRENTLY OFF) failed with: > > ERROR: unrecognized REPACK option "concurrently" > > even though REPACK (CONCURRENTLY ON) works correctly. That is, > CONCURRENTLY was treated as an unrecognized option when disabled.
Oh :-( > Second, when the same option is specified multiple times, the last value > is not always honored. In particular, if any occurrence sets an option to ON, > the option remains enabled even when the final setting is OFF. > > I think these are bugs, and the attached patch fixes them. Thoughts? I agree that these are bugs. The patch looks good to me on a cursory look, though I didn't actually test it. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
