On Tue, Apr 28, 2026 at 11:57 AM Peter Smith <[email protected]> wrote: > > On Fri, Apr 24, 2026 at 10:14 PM Álvaro Herrera <[email protected]> wrote: > > > > On 2026-Apr-24, Peter Smith wrote: > > > > > OK. Including the comma within a larger translated string seems like a > > > better idea. > > > > > > Since you now have the list `length`, I wondered why not simplify > > > further to use list_nth indexing? Then you can remove > > > `foreach_current_index` and `lc`. > > > > WFM. > > > > > Also, why did you choose to implement `last` versus `first` logic? > > > e.g. How about this? > > > > > { > > > if (first) > > > appendStringInfo(dest, _("\"%s\""), pubname); > > > else > > > appendStringInfo(dest, _(", \"%s\""), pubname); > > > } > > > > I don't know, it just seemed more natural. The whole ", foo" style > > simply feels weird to me. It seems a matter of choice only though, so > > if you feel strongly about this, I'm not opposed. > > > > Personally, I prefer `first` logic because > a) The length of the list is not required up-front > b) At each iteration, the built string makes sense instead of always > having a dangling ',' until the final iteration > > But it is not a big deal. This thread is about the translation part, > so whatever way makes the most sense for translators is fine with me. >
This thread has been inactive for about 5 weeks. AFAIK, everybody was happy with the patch, and we were only debating if the translated format string should have a leading comma or a trailing comma. Either way is OK with me -- whatever way you think makes the most sense to a translator. What can I do to help the patch proceed to get pushed? ====== Kind Regards, Peter Smith. Fujitsu Australia
