Looks good, I have one nitpick question: + if (isnull) + elog(WARNING, "null conbin for relation \"%s\"", + RelationGetRelationName(rel));
Shouldn't this be an error instead? Most existing checks treat it as an error, and that seems better to me as this shouldn't happen normally?
