Oops. > While looking into 0002, I noticed some minor ereport calling style > issues. > > Recently we start to use the style: > > ereport(ERROR, > errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > > Rather than (old style): > > ereport(ERROR, > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > > Grepping patches shows following results that hire the old style. > > $ grep -n '(errcode' *|grep '+' > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1243:+ > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1248:+ > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1421:+ > > (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1428:+ > > (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1451:+ > > (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1457:+ > > (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1463:+ > > (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1471:+ > (errcode(ERRCODE_SYNTAX_ERROR), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1494:+ > > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1504:+ > > (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
These have been fixed in 0007. Sorry for noise. Maybe this is the only one worth to look into? > nocfbot-0025-Reject-single-row-window-frame-in-row-pattern-rec.txt:55:+ > (errcode(ERRCODE_WINDOWING_ERROR), Regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
