On Tue, Jun 02, 2026 at 05:38:09PM -0700, Lukas Fittl wrote:
> I agree its not substantial, but its also not nothing - so I see
> Michael's point. I think the largest difference here is the fact that
> WalUsage and BufferUsage are repeated - that is something that would
> no longer be necessary once/if we go with the stack-based
> instrumentation approach. When I had this patch in the other patch
> series, it was after a refactoring that made the overhead much
> smaller.
> 
> Maybe for now I can re-order this patch series to lead with the other
> patches, and we could defer this part a bit until we have clarity what
> we're doing re: stack-based instrumentation.

Right.  That hints also to a patch ordering problem to me, where the
final picture (if I got correctly) would be that we don't have the
_start fields anymore at the end in the Instrumentation data sent.
It feels confusing that we push from the leader to its workers a set
of fields that the workers have no use for.
--
Michael

Attachment: signature.asc
Description: PGP signature

Reply via email to