Hi Sami,

Thanks for the review. I agree, rewriting the existing sentence reads
much better than appending a separate one.

I've adopted your suggestion in v2, with one addition: a sentence
noting that invalid indexes remain on the partition and
should be dropped manually if no longer needed.
I think this helps make it clear that the user is responsible for
cleaning those up.

The full paragraph now reads:

For each index in the target table, if a valid equivalent
index already exists in the partition, it will be attached
to the target table's index, as if ALTER INDEX ATTACH
PARTITION had been executed; otherwise, a corresponding
one will be created.  Any invalid indexes on the partition remain
unchanged and should be dropped manually if they are no longer
needed.

v2 patch attached.

-- 
Mohamed Ali

Attachment: v2-0001-doc-attach-partition-invalid-index-skip.patch
Description: Binary data

Reply via email to